-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for multiple facilities, metros and reservation IDs #7
Conversation
Signed-off-by: Avi Deitcher <[email protected]>
@deitch Thank you for your contribution. |
Signed-off-by: Avi Deitcher <[email protected]>
Signed-off-by: Avi Deitcher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was wrong, we will create one MachineClass
per facility, so you need exactly this value in the providerSpec
(not a list).
Looks like commenting is back (sort of).
I didn't understand it that way. Doesn't each worker pool in the |
OK, I missed that the EQXM can take multiple facilities when a device is created (contrary/different compared to how it's done for hyperscalers). In that case, forget about the previous review, it should be all good as is. |
I cannot get in to see the CI build error. Can you see what it is, so I can fix it? After that, I will test against live EQXM, and then we can merge in. |
Signed-off-by: Avi Deitcher <[email protected]>
OK, migration removed. Let's see if this passes. |
CI is clean! |
/hold until final tests were conducted |
I had to change the manifests and add a debug log line. Already tested:
Will be testing with reservations later today, then this can go in. |
cc39b34
to
c0441da
Compare
Signed-off-by: Avi Deitcher <[email protected]>
c0441da
to
83f4fe2
Compare
Signed-off-by: Avi Deitcher <[email protected]>
Signed-off-by: Avi Deitcher [email protected]
What this PR does / why we need it:
Adds support for:
Special notes for your reviewer:
This has not been properly tested yet. I need @rfranzke to review and make sure it aligns with gardener-extension-provider-packet 154, and then I can test it.
@rfranzke please take make sure I captured your target resource API correctly.
Release note: